search

openshift / jenkins-plugin

Apache License 2.0
81 stars 50 forks source link

Fix for empty namespace on oc-exec #115

Closed jupierce closed 7 years ago

jupierce commented 7 years ago

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1396022 ptal @gabemontero @bparees

gabemontero commented 7 years ago

IGTM (sorry I didn't catch that in earlier reviews)

Based on some PR testing I completed yesterday, the PR test job appears to be functional again. I'm going to let it play out before hitting the merge button.

gabemontero commented 7 years ago

The test job failed (unlike the ones I ran yesterday). The failures seem more server side though - certainly not related to this change.

Going to merge, and monitor PR job separately.