search

openshift / jenkins-plugin

Apache License 2.0
81 stars 50 forks source link

Patch / Update resources #121

Closed MarkRx closed 7 years ago

MarkRx commented 7 years ago

Hello,

Are there plans to be able to patch or update resources? I'm investigating the use of this plugin for deployments but I can't find a native jenkins way to perform patches or updates on existing resources. It would probably be used in conjunction with #110.

bparees commented 7 years ago

we're potentially looking at a secondary plugin that would expose the oc client more directly and would therefore expose things like apply.

we're hesitant to keep expanding this plugin to encompass every aspect of the oc tool. Not saying we won't do this particular item, but there is a tension about at what point it makes more sense to just shell out to oc to do certain things vs implementing jenkins build steps for each and every oc operation.

bparees commented 7 years ago

you can see a draft of the new plugin here, would be interested in your feedback: https://github.com/jupierce/openshift-jenkins-pipeline-dsl

bparees commented 7 years ago

@jupierce fyi

gabemontero commented 7 years ago

+1 to everything @bparees noted (was comprising a similar update when I saw this one posted).

That said, I've updated the corresponding trello card for get/describe to include patch/update as well.

jupierce commented 7 years ago

@MarkRx The example to look to is here: https://github.com/jupierce/openshift-jenkins-pipeline-dsl#need-to-update-an-object-without-replacing-it

Please let me know if you have any thoughts.

MarkRx commented 7 years ago

Yup. I have it built and am trying it and have submitted an issue :)

https://github.com/jupierce/openshift-jenkins-pipeline-dsl/issues/1

MarkRx commented 7 years ago

Would it need to be a separate plugin? Why not just make a step to run raw commands that integrates the code from https://github.com/jupierce/openshift-jenkins-pipeline-dsl?

gabemontero commented 7 years ago

That is in fact one path under consideration. Even entirely rebasing the old plugin on top of the new one may happen long term.

On Thu, Dec 22, 2016 at 8:41 AM Mark notifications@github.com wrote:

Would it need to be a separate plugin? Why not just make a step to run raw commands that integrates the code from https://github.com/jupierce/openshift-jenkins-pipeline-dsl?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/openshift/jenkins-plugin/issues/121#issuecomment-268801709, or mute the thread https://github.com/notifications/unsubscribe-auth/ADbadOHjZYmAKqZDzOgjxMp6yPsARPJ3ks5rKn4MgaJpZM4LTTOg .

bparees commented 7 years ago

we're going to provide this functionality via the new plugin, rather than also backport it to the existing plugin, so closing this issue.