search

openshift / jenkins-plugin

Apache License 2.0
81 stars 50 forks source link

bugfix: error message fstring requires state #134

Closed nicr9 closed 7 years ago

nicr9 commented 7 years ago

EXIT_DEPLOY_VERIFY_BAD_REPLICAS_BAD requires 4 arguments but we've only been passing 3. It seems that the missing argument is the value for state.

This bug causes a MissingFormatArgumentException if we're attempting to verify a deployment whos pods have entered a CrashBackOffLoop state.

openshift-bot commented 7 years ago

Can one of the admins verify this patch?

bparees commented 7 years ago

[test]

nicr9 commented 7 years ago

@gabemontero You're welcome =)

There's no hurry! We noticed the stacktrace while fleshing out our pipeline and it was unclear from the error message why the pipeline was failing. Once we figured it out it was because of CrashLoopBackOff we knew what to look for and were pretty happy.

I had some spare time on my hands so I thought I'd dig around for a fix ;)

gabemontero commented 7 years ago

OK sounds good @nicr9 . Even though you are not in a big hurry, I should be able to turn the crank on this within the next few days to a week.

nicr9 commented 7 years ago

Sounds great! :+1: