search

openshift / jenkins-plugin

Apache License 2.0
81 stars 50 forks source link

allow for env var subtitution for oc exec config #138

Closed gabemontero closed 7 years ago

gabemontero commented 7 years ago

Fixes https://github.com/openshift/jenkins-plugin/issues/135

@bparees @oatmealraisin ptal

bparees commented 7 years ago

does this allow for parameter references or just env references?

gabemontero commented 7 years ago

allows for both

bparees commented 7 years ago

lgtm

gabemontero commented 7 years ago

hmmm ... the extended test for freestyleexec failed (though dsl passed)

will run locally and debug

gabemontero commented 7 years ago

Fancy new iterator logic needs null checking:

Starting "OpenShift Exec" with project "extended-test-jenkins-plugin-g6bj4-3hk2n".
java.lang.NullPointerException
    at com.openshift.jenkins.plugins.pipeline.model.IOpenShiftExec.getArguments(IOpenShiftExec.java:49)
    at com.openshift.jenkins.plugins.pipeline.model.IOpenShiftExec.coreLogic(IOpenShiftExec.java:67)
    at com.openshift.jenkins.plugins.pipeline.model.IOpenShiftPlugin.doItCore(IOpenShiftPlugin.java:308)
    at com.openshift.jenkins.plugins.pipeline.model.IOpenShiftPlugin.doIt(IOpenShiftPlugin.java:326)
    at com.openshift.jenkins.plugins.pipeline.OpenShiftBaseStep.perform(OpenShiftBaseStep.java:81)
    at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
    at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
    at hudson.model.Build$BuildExecution.build(Build.java:206)
    at hudson.model.Build$BuildExecution.doRun(Build.java:163)
    at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
    at hudson.model.Run.execute(Run.java:1728)
    at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
    at hudson.model.ResourceController.execute(ResourceController.java:98)
    at hudson.model.Executor.run(Executor.java:405)
ERROR: "OpenShift Exec" failed
Finished: FAILURE