search

openshift / jenkins-plugin

Apache License 2.0
81 stars 50 forks source link

jenkins-plugin: add retry layer/adapter for REST invocations #141

Closed gabemontero closed 7 years ago

gabemontero commented 7 years ago 
Bug 1454485
Bugzilla link https://bugzilla.redhat.com/show_bug.cgi?id=1454485
Detailed explanation
Implement a general retry mechanism for failing HTTP REST operations
against the OpenShift master

@bparees @oatmealraisin FYI

gabemontero commented 7 years ago

Ah ... the httpGet path needs some work

gabemontero commented 7 years ago

ok tests are clean now with some more tweaks to the error handling .. have 1 more mod I'm about to try

gabemontero commented 7 years ago

interesting ... a concurrent mod in this run uncovered a NPE ... will address NPE, and investigate if there is a deeper issue wrt retry

gabemontero commented 7 years ago

ah yes ... the master sends back an HTTP rc 409, which the restclient does not deal with specifically ... we already had retry for this higher up the plugin stack

IMO simply addressing the NPE in the new logic is sufficient ... will push momentarily

gabemontero commented 7 years ago

OK ... tests are looking good.

@bparees - any more suggestions before merging?

bparees commented 7 years ago

lgtm