search

openshift / jenkins-plugin

Apache License 2.0
81 stars 50 forks source link

Set jenkins+build uri as the reason on build request #56

Closed bparees closed 8 years ago

bparees commented 8 years ago

now that we can set a cause on a buildrequest, we should set jenkins as the cause with the job uri (same value we are annotating on the build object itself).

https://github.com/openshift/origin/blob/master/pkg/build/api/v1/types.go#L789

@spadgett

Message should be something like "Jenkins job URI https://blahblah/blah"

the ui will then be able to filter on this value.

gabemontero commented 8 years ago

This will necessitate a change to openshift-restclient-java (which I can do and then submit a PR for @jcantrill 's review) and invariable upgrade in that dependency.

@bparees @spadgett - I'm assuming we want this prior to 3.3 going out. Correct?

bparees commented 8 years ago

@gabemontero ideally. @spadgett says he can live w/o it.

gabemontero commented 8 years ago

@bparees @spadgett I have a prototype of this that is working. Given the amount of additional changes needed to upgrade the openshift-restclient as well as make the modifications to the restclient to set the cause (where I still have to submit a pull for that), I'm not ready to produce a publicly consumable plugin to try, but I can provide a locally built version if you want to try sooner rather than later.

I hope to have the thing ready for public consumption by sometime tomorrow at the latest .... maybe EOB today, but I'm betting that is optimistic.

gabemontero commented 8 years ago

Quick update - still waiting for the openshift-restclient-java PR to merge. Not much contention in the PR - just some lag time.

jcantrill commented 8 years ago

@gabemontero PR merged and 5.0.0-SNAPSHOT deployed

gabemontero commented 8 years ago

thanks @jcantrill !!

gabemontero commented 8 years ago

OK @spadgett here is a pre-release version of the plugin that registers a build cause for build triggered from the plugin.

When you get the chance please give it a try, and if we need to make tweaks, let's iterate over them.

I'll leave the issue open for bit in case you get a chance to try in the short term. Otherwise I'm going to close this out as a result of https://github.com/openshift/jenkins-plugin/commit/070689c63b233529cfa52d60f145d7391e99e50b