search

openshift / jenkins-plugin

Apache License 2.0
81 stars 50 forks source link

Resolve #66 duplication in Jenkins console output #67

Closed jim-minter closed 8 years ago

jim-minter commented 8 years ago

Don't recreate pod listeners multiple times - do it once when the build status gets to Running

fixes https://github.com/openshift/jenkins-plugin/issues/66

gabemontero commented 8 years ago

@jim-minter for future reference, if you add "fixes " in description of PR, git will automatically close the issue when the PR merges

jim-minter commented 8 years ago

@gabemontero thanks for the hint!

gabemontero commented 8 years ago

Cool deal @jim-minter!!! I'll merge when i get back to my desk.

On Tuesday, September 27, 2016, Jim Minter notifications@github.com wrote:

@jim-minter commented on this pull request.

In src/main/java/com/openshift/jenkins/plugins/pipeline/ model/IOpenShiftBuilder.java https://github.com/openshift/jenkins-plugin/pull/67:

@@ -107,7 +107,7 @@ default void waitOnBuild(IClient client, long startTime, String bldId, TaskListe if (Boolean.parseBoolean(getVerbose(overrides))) listener.getLogger().println("\nOpenShiftBuilder bld state: " + bldState);

  • if (follow) {
  • if (follow && bldState.equals("Running") && stop == null) {

Yes, I have rebuilt it and tried it out. I added the stop == null as the catch to avoid the streaming being created multiple times.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/openshift/jenkins-plugin/pull/67, or mute the thread https://github.com/notifications/unsubscribe-auth/ADbadMxxf_zbmzwieJYKJm2jJAZsiJwsks5quU0MgaJpZM4KH1tP .

gabemontero commented 8 years ago

Yw and thanks again for the fix

On Tuesday, September 27, 2016, Jim Minter notifications@github.com wrote:

@gabemontero https://github.com/gabemontero thanks for the hint!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openshift/jenkins-plugin/pull/67#issuecomment-249930400, or mute the thread https://github.com/notifications/unsubscribe-auth/ADbadOLRE_-eMGgmhDyqvBisF_nkK7Kuks5quU0mgaJpZM4KH1tP .