Timeout fixes - Githubissues

openshift / jenkins-plugin

Apache License 2.0

81 stars 50 forks source link

Timeout fixes #78

Closed jupierce closed 8 years ago

jupierce commented 8 years ago

Fixes:

Several areas of the code were using the following to look up timeout values: getOverrides(getWaitTime(), overrides ). This ultimately looked up the user specified integer value in the overrides keymap. I don't think this was intentional.
Several areas of the code were not using the GlobalConfig values.
All timeout value handling has been moved into a few classes for consistency and maintainability.

ptal @gabemontero

fwiw, this should also simplify @oatmealraisin 's pull for timeout units.

jupierce commented 8 years ago

@gabemontero educated me on the reason getOverride(getTimeout(),overrides) was being used: Users should be able to specify variables within the fields. Minor change to incorporate this feature.

jupierce commented 8 years ago

@gabemontero

Loosened validation of waitTime to allow for variable names.
Migrated all common doCheck descriptor methods into a single interface: IOpenShiftPluginDescriptorValidation

jupierce commented 8 years ago

@gabemontero Restored GlobalConfig.getDefaultX to GlobalConfig.getX .

gabemontero commented 8 years ago

On Fri, Oct 7, 2016 at 3:10 PM, Justin Pierce notifications@github.com wrote:

@gabemontero https://github.com/gabemontero Restored GlobalConfig.getDefaultX to GlobalConfig.getX .

thx @jupierce

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openshift/jenkins-plugin/pull/78#issuecomment-252336776, or mute the thread https://github.com/notifications/unsubscribe-auth/ADbadIC--x-ACYjik1PaiD3acurJgtKEks5qxpk_gaJpZM4KRIDK .

gabemontero commented 8 years ago

On the rebase comments, @jupierce , @oatmealraisin , and I linked up. We are going to go with the wait time related changes in this PR, and then @jupierce is going to help with the resulting churn in @oatmealraisin 's PR where wait units are introduced.