search

openshift / jenkins

Apache License 2.0
260 stars 446 forks source link

OCPBUGS-8437: Fix labels for jenkins-slave-base-rhel8 #1593

Closed liangxia closed 1 year ago

liangxia commented 1 year ago

slave-base/Dockerfile.rhel8 should label with rhel8, which is labeled with rhel7 currently.

liangxia commented 1 year ago

/test e2e-aws-jenkins-sync-plugin

coreydaley commented 1 year ago

The jenkins-sync-plugin job failing is a known issue that we are currently working to resolve. /hold until the job is fixed

coreydaley commented 1 year ago

/hold cancel /retest

coreydaley commented 1 year ago

/lgtm

@liangxia Are you planning to backport this fix? If you can backport it to 4.13, 4.12 and 4.11 that would be fine.

coreydaley commented 1 year ago

/approve

liangxia commented 1 year ago

@liangxia Are you planning to backport this fix? If you can backport it to 4.13, 4.12 and 4.11 that would be fine.

@coreydaley Backport to 4.13~4.9

coreydaley commented 1 year ago

@liangxia Please update this pull request to fix the labels in the rest of the Dockerfile.rhel8 files (we might as well fix them all at once).

Don't open manual pull requests for the backports, we have a system for making that easier once this pull request is good we can cherry-pick them. We will also need a bug opened and linked here in the title of the pull request so that we can cherry-pick.

coreydaley commented 1 year ago

/hold

openshift-ci-robot commented 1 year ago

@liangxia: This pull request references Jira Issue OCPBUGS-8437, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/jenkins/pull/1593): >`slave-base/Dockerfile.rhel8` should label with rhel8, which is labeled with rhel7 currently. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
liangxia commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@liangxia: This pull request references Jira Issue OCPBUGS-8437, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @coreydaley

In response to [this](https://github.com/openshift/jenkins/pull/1593#issuecomment-1457386308): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coreydaley commented 1 year ago

/hold cancel /lgtm /cherry-pick release-4.13

openshift-cherrypick-robot commented 1 year ago

@coreydaley: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/jenkins/pull/1593#issuecomment-1457386837): >/hold cancel >/lgtm >/cherry-pick release-4.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/jenkins/blob/master/OWNERS)~~ [coreydaley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@liangxia: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 year ago

@liangxia: Jira Issue OCPBUGS-8437: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-8437 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/jenkins/pull/1593): >`slave-base/Dockerfile.rhel8` should label with rhel8, which is labeled with rhel7 currently. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 year ago

@coreydaley: new pull request created: #1612

In response to [this](https://github.com/openshift/jenkins/pull/1593#issuecomment-1457386837): >/hold cancel >/lgtm >/cherry-pick release-4.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.