search

openshift / jenkins

Apache License 2.0
260 stars 447 forks source link

JKNS-337: Updating README and associated in-repo documents #1653

Closed coreydaley closed 1 year ago

coreydaley commented 1 year ago

The goal of this PR is to:

Please review as appropriate.

coreydaley commented 1 year ago

/assign @divyansh42 @mbharatk @apoorvajagtap for lgtm

openshift-ci-robot commented 1 year ago

@coreydaley: This pull request references JKNS-337 which is a valid jira issue.

In response to [this](https://github.com/openshift/jenkins/pull/1653): >The goal of this PR is to: > - Remove references to OpenShift 3.11 > - Remove references to OpenShift 4.10 and earlier > - Split monolithic README.md file into separate documents based on content. > >Please review as appropriate. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@coreydaley: This pull request references JKNS-337 which is a valid jira issue.

In response to [this](https://github.com/openshift/jenkins/pull/1653): >The goal of this PR is to: > - Remove references to OpenShift 3.11 > - Remove references to OpenShift 4.10 and earlier > - Split monolithic README.md file into separate documents based on content. > >Please review as appropriate. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coreydaley commented 1 year ago

/assign @divyansh42 @mbharatk @apoorvajagtap for lgtm

apoorvajagtap commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apoorvajagtap, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/jenkins/blob/master/OWNERS)~~ [coreydaley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@coreydaley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
avinal commented 1 week ago

/cherry-pick release-4.13

openshift-cherrypick-robot commented 1 week ago

@avinal: #1653 failed to apply on top of branch "release-4.13":

Applying: Updating Jenkins documentation
Using index info to reconstruct a base tree...
M   README.md
Falling back to patching base and 3-way merge...
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
Removing CHANGELOG.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Updating Jenkins documentation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/jenkins/pull/1653#issuecomment-2331556767): >/cherry-pick release-4.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.