openshift / jenkins

Apache License 2.0
260 stars 447 forks source link

[JKNS-346] Bump workflow_cps, kubernetes, kubernetes_client_api plugins #1659

Closed apoorvajagtap closed 1 year ago

apoorvajagtap commented 1 year ago

Bumping the plugins to meet the requirements for openshift-sync-plugin v1.0.56.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apoorvajagtap Once this PR has been reviewed and has the lgtm label, please assign divyansh42 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/jenkins/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coreydaley commented 1 year ago

/retest infra issues

coreydaley commented 1 year ago

`com.google.inject.ProvisionException: Unable to provision, see the following errors:

1) [Guice/ErrorInjectingConstructor]: NoSuchMethodError: 'okhttp3.OkHttpClient DefaultOpenShiftClient.getHttpClient()' at GlobalPluginConfiguration.(GlobalPluginConfiguration.java:109)

Learn more: https://github.com/google/guice/wiki/ERROR_INJECTING_CONSTRUCTOR

1 error`

This is an error that I was afraid we would run into eventually, it seems to be an incompatibility between the kubernetes client version, it changed at something like 5.10.something or 5.11 to be incompatible. Let's sync up about this later today and see if we can get it fixed up without having to rewrite anything major :)

coreydaley commented 1 year ago

/retest

openshift-ci[bot] commented 1 year ago

@apoorvajagtap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-jenkins-sync-plugin aa5f2218b28f10b06cca599128a3a7bc458e2f8f link true /test e2e-aws-jenkins-sync-plugin
ci/prow/e2e-aws-jenkins-client-plugin aa5f2218b28f10b06cca599128a3a7bc458e2f8f link true /test e2e-aws-jenkins-client-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
saschalaudien commented 1 year ago

@coreydaley We see the same issue when trying to upgrade the Kubernetes Plugin. We are even forced to upgrade the kubernetes plugin to a much more current version(3910.ve59cec5e33ea_) then you are trying to integrate(1.31.2). This is because of the latest Jenkins Security Advisory: https://www.jenkins.io/security/advisory/2023-04-12/

But I also made the test with the version(1.31.2) you are trying to integrate and receive the same error.

Would be great if you can find a solution for this so that we can upgrade the plugin and fix the issue from the Jenkins Security Advisory. Thanks.

coreydaley commented 1 year ago

@coreydaley We see the same issue when trying to upgrade the Kubernetes Plugin. We are even forced to upgrade the kubernetes plugin to a much more current version(3910.ve59cec5e33ea_) then you are trying to integrate(1.31.2). This is because of the latest Jenkins Security Advisory: https://www.jenkins.io/security/advisory/2023-04-12/

But I also made the test with the version(1.31.2) you are trying to integrate and receive the same error.

Would be great if you can find a solution for this so that we can upgrade the plugin and fix the issue from the Jenkins Security Advisory. Thanks. I have a series of pull requests open to the various openshift jenkins and openshift jenkins plugin repositories that i am hopeful will fix the issues, and i am working on testing them all together today.

coreydaley commented 1 year ago

@saschalaudien I have no idea how I quoted your reply and posted it and didn't add my thoughts to it :( Long day I guess ...

We have pull requests open to each of our Jenkins OpenShift plugin repositories along with one to our main Jenkins image repository that we are testing that should take care of all of this nonsense, hoping to get them all tested and merged this week and then released as new images shortly after that.

saschalaudien commented 1 year ago

@coreydaley No worries. But I also asked myself about the meaning of your reply ;-)

Thanks for your answer. I wish you the best to get all of the stuff fixed and tested. Would be great if you can post here the link to the fixed Jenkins image and the versions of the plugins we need to upgrade.

Have a nice day.

coreydaley commented 1 year ago

/hold until https://github.com/openshift/jenkins/pull/1666 merges and then we will rebase and see if it is still needed

coreydaley commented 1 year ago

/close This has been taken care of by https://github.com/openshift/jenkins/pull/1666

openshift-merge-robot commented 1 year ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@coreydaley: Closed this PR.

In response to [this](https://github.com/openshift/jenkins/pull/1659#issuecomment-1544544435): >/close >This has been taken care of by https://github.com/openshift/jenkins/pull/1666 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
saschalaudien commented 1 year ago

@coreydaley Any ideas when a Jenkins Openshift Image with this fix (https://github.com/openshift/jenkins/pull/1666) will be available in the RedHat Catalog?

coreydaley commented 1 year ago

No specific dates but we are working on it and hope to release it very soon.