[JKNS-345] Remove all legacy pieces from Jenkins repository

[mbharatk]

Removing all the unused legacy Docker files, agents, and unused scripts.

[mbharatk]

/assign @coreydaley

[mbharatk]

/retest

[coreydaley]

There may be a pull request needed to openshift/release first to remove the building of the nodejs and maven images, or something similar in the process that needs to be disabled first

[coreydaley]

The makefile also, I believe, automatically tries to build the nodejs and maven images, so it will need to be changed also: https://github.com/openshift/jenkins/blob/master/Makefile#L11

[mbharatk]

@coreydaley I'm going through openshift/release to find the maven and nodejs image building and found these https://github.com/mbharatk/release/blob/6cb71e19022aed34a8e6d21dc1798b90bab4dc26/ci-operator/config/openshift/jenkins/openshift-jenkins-master.yaml#L37-L54 and https://github.com/mbharatk/release/blob/6cb71e19022aed34a8e6d21dc1798b90bab4dc26/ci-operator/config/openshift/jenkins-openshift-login-plugin/openshift-jenkins-openshift-login-plugin-master.yaml#L6-L9

Along with these I'll also look for anything else that should be removed

[mbharatk]

@coreydaley should this also be changed to rhel8 ans what about the centos7, is it deprecated?

[coreydaley]

@coreydaley should this also be changed to rhel8 ans what about the centos7, is it deprecated?

Probably

[coreydaley]

Are you able to run the make build command on your local machine and have it work without throwing any errors?

[coreydaley]

@mbharatk Yes, lets go ahead and setup a pull request to remove https://github.com/mbharatk/release/blob/6cb71e19022aed34a8e6d21dc1798b90bab4dc26/ci-operator/config/openshift/jenkins/openshift-jenkins-master.yaml#L37-L54 first, i think that is causing the main issue with your pull request here.

[coreydaley]

/retest

[coreydaley]

nodejs and maven imagestreams should also be removed: https://github.com/openshift/jenkins/tree/master/openshift/imagestreams

[coreydaley]

Looks like there are some smoke tests that refer to the nodejs and maven images also: https://github.com/coreydaley/openshift-jenkins/blob/master/smoke/features

[coreydaley]

It would be worth running the following commands to see what is left that could be removed:

# find . -name "*maven*" | grep -v ".git"
# grep -r "maven" * 
# find . -name "*nodejs*" | grep -v ".git"
# grep -r "nodejs" *

[coreydaley]

/hold while we remove more items that refer to maven and nodejs

[coreydaley]

/lgtm /label px-approved /label docs-approved /label qe-approved

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, mbharatk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/jenkins/blob/master/OWNERS)~~ [coreydaley,mbharatk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[coreydaley]

/hold cancel

[coreydaley]

/refresh

[fbm3307]

@coreydaley @mbharatk @jkhelil These Imagestreams needs to be removed too from openshift/library, as they are referenced there for Samples operator, this will break Samples operator at current time also. These can be removed from https://github.com/openshift/library/blob/bf0aaccbe8d48e85c6c570947b46586ca844a6b5/official.yaml#L230-L314