Closed apoorvajagtap closed 1 year ago
/assign @coreydaley @divyansh42 @mbharatk Please feel free to test & share your inputs (Needs a cluster ready):
$ curl -o /tmp/second-phase.sh https://raw.githubusercontent.com/apoorvajagtap/jenkins/deploy_jenkins_openshift_script/scripts/verify-jenkins-on-openshift.sh && chmod +x /tmp/second-phase.sh
$ /tmp/second-phase.sh
@coreydaley thank you for looking through! I've made the suggested changes. Let me know in case I've missed anything.
The script would need two args now:
$ curl -o /tmp/second-phase.sh https://raw.githubusercontent.com/apoorvajagtap/jenkins/deploy_jenkins_openshift_script/scripts/verify-jenkins-on-openshift.sh && chmod +x /tmp/second-phase.sh
$ /tmp/second-phase.sh -i <jenkins_image> -s <commit_sha>
I like the script so far, but I think we can improve it
Thoughts?
With latest commit, the script does the following:
@coreydaley please let me know, if this meets the expected criteria? Or, in order to run e2e tests against the pod, we'll need some additional configurations in the pod?
/assign @coreydaley @divyansh42 @mbharatk
@apoorvajagtap: all tests passed!
Full PR test history. Your PR dashboard.
/approve /lgtm /label px-approved /label docs-approved /label qe-approved
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: apoorvajagtap, coreydaley
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The script
verify-jenkins-on-openshift.sh
takes the following inputs:& Automates the following tasks:
quay.io/pipeline-integrations
.