openshift / jenkins

Apache License 2.0
260 stars 447 forks source link

[JKNS-344] Second phase of self-verification process for Jenkins #1662

Closed apoorvajagtap closed 1 year ago

apoorvajagtap commented 1 year ago

The script verify-jenkins-on-openshift.sh takes the following inputs:

& Automates the following tasks:

apoorvajagtap commented 1 year ago

/assign @coreydaley @divyansh42 @mbharatk Please feel free to test & share your inputs (Needs a cluster ready):

$ curl -o /tmp/second-phase.sh https://raw.githubusercontent.com/apoorvajagtap/jenkins/deploy_jenkins_openshift_script/scripts/verify-jenkins-on-openshift.sh && chmod +x /tmp/second-phase.sh
$ /tmp/second-phase.sh
apoorvajagtap commented 1 year ago

@coreydaley thank you for looking through! I've made the suggested changes. Let me know in case I've missed anything.

apoorvajagtap commented 1 year ago

The script would need two args now:

$ curl -o /tmp/second-phase.sh https://raw.githubusercontent.com/apoorvajagtap/jenkins/deploy_jenkins_openshift_script/scripts/verify-jenkins-on-openshift.sh && chmod +x /tmp/second-phase.sh
$ /tmp/second-phase.sh -i <jenkins_image> -s <commit_sha>
coreydaley commented 1 year ago

I like the script so far, but I think we can improve it

  1. Have it run the image locally first and run the verify script inside of it
  2. if that passes, THEN have it run the image on an openshift cluster and run the e2e tests against it from the openshift/jenkins repo (make e2e).

Thoughts?

apoorvajagtap commented 1 year ago

With latest commit, the script does the following:

  1. Runs a container with CPaas image, executes verify_jenkins.sh within the container.
  2. If all tests succeed in 1, deploys a pod on OpenShift using the same CPaas image, & shares the pod details with the user.
  3. If the tests fail in 1, exits, and shares the details about a file with the output(errors).

@coreydaley please let me know, if this meets the expected criteria? Or, in order to run e2e tests against the pod, we'll need some additional configurations in the pod?

apoorvajagtap commented 1 year ago

/assign @coreydaley @divyansh42 @mbharatk

openshift-ci[bot] commented 1 year ago

@apoorvajagtap: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
coreydaley commented 1 year ago

/approve /lgtm /label px-approved /label docs-approved /label qe-approved

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apoorvajagtap, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/jenkins/blob/master/OWNERS)~~ [coreydaley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment