search

openshift / jenkins

Apache License 2.0
260 stars 447 forks source link

Updating Jenkins Go tests to use Podman instead of Docker #1664

Closed coreydaley closed 1 year ago

coreydaley commented 1 year ago

The agent-base tests can be run locally, but the server tests must be run on an openshift cluster (or against one, but i haven't investigated how yet). These used to run using a jenkins server that OpenShift had setup which had docker installed, but that instance went away and we had to disable the test. I think with the current changes we should be able to get them running again via some configuration in openshift/release. If these tests look OK we will need to do some coordination between openshift/jenkins and openshift/release to get them enabled.

coreydaley commented 1 year ago

/hold for discussion

/assign @divyansh42 @mbharatk @apoorvajagtap for discussion

coreydaley commented 1 year ago

/hold cancel

apoorvajagtap commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apoorvajagtap, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/jenkins/blob/master/OWNERS)~~ [coreydaley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coreydaley commented 1 year ago

/label px-approved /label docs-approved /label qe-approved

openshift-ci-robot commented 1 year ago

/retest-required

Remaining retests: 0 against base HEAD 10adc6bfea4534b0535c374126f8dfd49b365de9 and 2 for PR HEAD 07ea28ce0a89fed71fb5965f3466bccf496a570b in total

openshift-ci[bot] commented 1 year ago

@coreydaley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).