openshift / jenkins

Apache License 2.0
260 stars 447 forks source link

OCPBUGS-21634, OCPBUGS-21747: git-init: fix NPE when killing a process #1692

Closed InQuirer closed 1 year ago

InQuirer commented 1 year ago

fixes #1690

openshift-ci[bot] commented 1 year ago

Hi @InQuirer. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coreydaley commented 1 year ago

/test all

coreydaley commented 1 year ago

/retest

coreydaley commented 1 year ago

/retest

coreydaley commented 1 year ago

/approve /assign @apoorvajagtap for review and lgtm

coreydaley commented 1 year ago

/label px-approved /label docs-approved /label qe-approved

apoorvajagtap commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apoorvajagtap, coreydaley, InQuirer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/jenkins/blob/master/OWNERS)~~ [coreydaley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@InQuirer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
divyansh42 commented 10 months ago

/retitle OCPBUGS-21747: git-init: fix NPE when killing a process

openshift-ci-robot commented 10 months ago

@InQuirer: Jira Issue OCPBUGS-21747: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21747 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/jenkins/pull/1692): >fixes #1690 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
divyansh42 commented 10 months ago

/retitle OCPBUGS-21634, OCPBUGS-21747: git-init: fix NPE when killing a process

divyansh42 commented 10 months ago

/jira refresh

openshift-ci-robot commented 10 months ago

@divyansh42: Jira Issue OCPBUGS-21747 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to [this](https://github.com/openshift/jenkins/pull/1692#issuecomment-1770158921): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.