openshift / jenkins

Apache License 2.0
260 stars 447 forks source link

Installing Java 17 instead of Java 8 #1708

Closed AlbertoPimpo closed 7 months ago

AlbertoPimpo commented 1 year ago

Since Java 8 is no more compatible with Jenkins since version 2.361.1 (see jenkins docs), so there is no more reason to install it in the image.

Instead, since the same version (see jenkins docs), Jenkins supports Java 17, so it makes sense to install it in the image so that early adopters can already try it.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlbertoPimpo Once this PR has been reviewed and has the lgtm label, please assign coreydaley for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/jenkins/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

Hi @AlbertoPimpo. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coreydaley commented 1 year ago

We can add Java 17 probably, but we can not remove Java 8 yet. There are some users which may still use Java 8 in their jobs so we want it to continue to be available.

AlbertoPimpo commented 1 year ago

We can add Java 17 probably, but we can not remove Java 8 yet. There are some users which may still use Java 8 in their jobs so we want it to continue to be available.

I'm not sure how many people are going to use it. Consider that by default the execution of jobs in the built-in node is de facto disabled (configured with 0 executors) and in general is discouraged (see jenkins docs).

coreydaley commented 1 year ago

I believe that in our images that is not disabled by default yet.

AlbertoPimpo commented 10 months ago

I believe that in our images that is not disabled by default yet.

You're actually right. I checked and the built-in node is not disabled by default, it is used if it is the only node that you have.

So, the only case in which you could benefit having Java 8 is the case in which you don't have any external node or k8s integration and you need to run a specific job that can only run on Java 8. Given that, I think it is safe to drop it. If you don't think so I will put it back in the PR.

openshift-bot commented 7 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

coreydaley commented 7 months ago

/close

openshift-ci[bot] commented 7 months ago

@coreydaley: Closed this PR.

In response to [this](https://github.com/openshift/jenkins/pull/1708#issuecomment-1911310646): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.