OCPTOOLS-393: Revert Incomplete Template Update

[adambkaplan]

Reverts openshift/jenkins#1706, which switched the Jenkins templates to use Deployment from DeploymentConfig. This was an incomplete and left the template with an invalid pod template spec (container image was empty).

[openshift-ci-robot]

@adambkaplan: This pull request references OCPTOOLS-393 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/jenkins/pull/1773): >Reverts openshift/jenkins#1706, which switched the Jenkins templates to use `Deployment` from `DeploymentConfig`. This was an incomplete and left the template with an invalid pod template spec (container image was empty). Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fjenkins). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[sayan-biswas]

/approve /lgtm

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/jenkins/blob/master/OWNERS)~~ [sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 46b3556560d4faade7c458e69f6a45cb0caf2741 and 2 for PR HEAD c4b6a1a19c2710d3f80c5ce1c23317f9bac7b025 in total

[openshift-ci[bot]]

@adambkaplan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	c4b6a1a19c2710d3f80c5ce1c23317f9bac7b025	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[adambkaplan]

/hold

We need to investigate why the sync plugin tests are failing.

[sayan-biswas]

@adambkaplan This test is failing for the other PRs also. From the logs it seems the issue is with the nodejs-postgres-ex example with the npm test https://github.com/openshift/jenkins-sync-plugin/blob/16baf49114eda4f55da2029034964f4aaafdc92f/test/e2e/testobjects.go#L364

We have a failure in the step TestBlueGreen

> nyc --reporter=lcov mocha

        sh: nyc: command not found
        error: build error: building at STEP "RUN /bin/sh -ic 'npm test'": while running runtime: exit status 127
    sync_plugin_test.go:335: unexpected results for job/jenkins-sync-plugin-test-namespace-tbc8r/job/jenkins-sync-plugin-test-namespace-tbc8r-bluegreen-pipeline/1/consoleText
--- FAIL: TestBlueGreen (683.28s)

[ramessesii2]

/test e2e-aws-jenkins-sync-plugin

[adambkaplan]

/hold cancel

Sync plugin test fixed

[openshift-cherrypick-robot]

@ramessesii2: new pull request created: #1778

In response to [this](https://github.com/openshift/jenkins/pull/1773#issuecomment-2081928181): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[ramessesii2]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@ramessesii2: new pull request created: #1790

In response to [this](https://github.com/openshift/jenkins/pull/1773#issuecomment-2093165754): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.