search

openshift / kube-compare

A Kubectl plugin to allow to compare a known valid reference configuration and a set of specific cluster configuration CRs.
Apache License 2.0
8 stars 8 forks source link

Converted to Separate Execution of Diff Command for Each CR #10

Closed AlinaSecret closed 1 month ago

AlinaSecret commented 2 months ago

This commit changes the run behavior of the diff command to execute separately for each CR instead of running the diff command once for all CRs. This change enables easy tracking of the number of CRs containing differences, and they are now added to the command output. Additionally, this change generates separate output for each CR, enabling the addition of additional information to each presented diff. For each found diff, the CR name and its correlated matching template name are now presented. Furthermore, a separator string has been added between each diff to allow clearer separation between CRs diff outputs. Also, the titles of the command summary output have been changed to be more informative.

AlinaSecret commented 2 months ago

/retest

AlinaSecret commented 2 months ago

/retest

AlinaSecret commented 2 months ago

/cc @imiller0 /cc @pixelsoccupied cc: @ardaguclu

AlinaSecret commented 1 month ago

@ardaguclu Thanks for the review! i really appreciate it :)

openshift-ci[bot] commented 1 month ago

@AlinaSecret: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
pixelsoccupied commented 1 month ago

/lgtm /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixelsoccupied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kube-compare/blob/main/OWNERS)~~ [pixelsoccupied] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment