search

openshift / kube-compare

A Kubectl plugin to allow to compare a known valid reference configuration and a set of specific cluster configuration CRs.
Apache License 2.0
8 stars 8 forks source link

Change command behavior to skip invalid resources in local mode #18

Open AlinaSecret opened 1 month ago

AlinaSecret commented 1 month ago

previously, when using the command in local mode with recursive mode enabled, the command would attempt to parse additional JSON/YAML files as resources. If any files were invalid, an error was presented to the user, and the compare results for other valid resources were not returned.

With this update, the command will now issue a warning for invalid resources instead of stopping execution. It will skip these problematic files and proceed to present the compare results for the valid resources.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from alinasecret. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/kube-compare/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AlinaSecret commented 1 week ago

/cc @pixelsoccupied @nocturnalastro

pixelsoccupied commented 1 week ago

/lgtm

openshift-ci[bot] commented 5 days ago

New changes are detected. LGTM label has been removed.

AlinaSecret commented 5 days ago

@pixelsoccupied only fixed the tests from the lgtm (removed whitespace that was changed in previous merge)

openshift-ci[bot] commented 5 days ago

@AlinaSecret: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).