search

openshift / kube-compare

A Kubectl plugin to allow to compare a known valid reference configuration and a set of specific cluster configuration CRs.
Apache License 2.0
8 stars 8 forks source link

clarify the success messages during live mode #27

Closed pixelsoccupied closed 1 week ago

pixelsoccupied commented 3 weeks ago

Success messages when running against live cluster should be clarified a bit more.

Feel free to suggest any alt. Basically the goal is to be able to tell "All good" at a quick glance 

#prev

Summary
CRs with diffs: 1
No CRs are missing from the cluster
No CRs are unmatched to reference CRs
# cur 

Summary
Diff count: 1
Successfully found all required resources from the cluster
Successfully compared all reference resources

Additional update the gitignore to ignore local build

/cc @AlinaSecret @nocturnalastro

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from pixelsoccupied. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/kube-compare/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pixelsoccupied commented 3 weeks ago

/hold

openshift-ci[bot] commented 2 weeks ago

@pixelsoccupied: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/golint 6ab0b382b95ac298c4ea5a7d0f37080de1f623b9 link true /test golint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-merge-robot commented 2 weeks ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-merge-robot commented 2 weeks ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
pixelsoccupied commented 1 week ago

/close Closing this for now. Will revisit this later after some discussion if needed!

openshift-ci[bot] commented 1 week ago

@pixelsoccupied: Closed this PR.

In response to [this](https://github.com/openshift/kube-compare/pull/27#issuecomment-2181260803): >/close >Closing this for now. Will revisit this later after some discussion if needed! Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.