Closed hhamid93 closed 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign pixelsoccupied for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @hhamid93. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/hold
getting a markdown linter ci job shortly https://github.com/openshift/release/pull/51328
/unhold /ok-to-test
@hhamid93 thanks for this contribution! Really good updates, I left a couple comments.
PR needs rebase.
@hhamid93: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/unit | 75cb5eea927f38867f404ee4678f04f59d68896a | link | true | /test unit |
ci/prow/markdownlint | 75cb5eea927f38867f404ee4678f04f59d68896a | link | true | /test markdownlint |
Full PR test history. Your PR dashboard.
See some suggested updates for the user guide and README doc