search

openshift / kube-compare

A Kubectl plugin to allow to compare a known valid reference configuration and a set of specific cluster configuration CRs.
Apache License 2.0
8 stars 8 forks source link

Reverse the left/right terms in the diff #6

Closed imiller0 closed 2 months ago

imiller0 commented 2 months ago

The reference configuration is the "baseline" and the live cluster is what is being validated. Reversing the order in the diff ensures that the + means "live cluster has this additional line" and - means "live cluster is missing this line"

pixelsoccupied commented 2 months ago

/lgtm

AlinaSecret commented 2 months ago

/test all

AlinaSecret commented 2 months ago

/lgtm

AlinaSecret commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

@imiller0: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
pixelsoccupied commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixelsoccupied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kube-compare/blob/main/OWNERS)~~ [pixelsoccupied] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment