Fix Misformatted Reference Configurations in Tests

openshift / kube-compare

A Kubectl plugin to allow to compare a known valid reference configuration and a set of specific cluster configuration CRs.

Apache License 2.0

8 stars 8 forks source link

Fix Misformatted Reference Configurations in Tests #8

Closed AlinaSecret closed 2 months ago

AlinaSecret commented 2 months ago

Fixed multiple tests where the reference config used by the tests was misformatted, and now it correctly follows templating syntax. Most of the mistakes were in curly brackets that were separated by spaces instead of being without spaces. After this fix, the tests should accurately validate the expected behavior.

openshift-ci[bot] commented 2 months ago

@AlinaSecret: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

pixelsoccupied commented 2 months ago

/lgtm /approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixelsoccupied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kube-compare/blob/main/OWNERS)~~ [pixelsoccupied] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment