search

openshift / kubefed-operator

Operator for Kubefed
Apache License 2.0
15 stars 15 forks source link

Update the value of DEFAULT_KUBEFED_SCOPE env if it exists #72

Closed abhat closed 5 years ago

abhat commented 5 years ago

This PR handles the case where the DEFAULT_KUBEFED_SCOPE env variable exists, but its value is not the same as the current value of the Scope field of the instance of KubeFed being reconciled.

abhat commented 5 years ago

/assign @pmorie

sohankunkerkar commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kubefed-operator/blob/master/OWNERS)~~ [abhat,sohankunkerkar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment