openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

Bug 2082075: Parallelize ports removal #655

Closed gryf closed 2 years ago

gryf commented 2 years ago

During removal of Neutron resources, sometimes there could be hanging orphaned ports. Till now, all the removal was done one by one which slows down removing process. In this change there is introduced removing port in parallel in five concurrently run workers.

Change-Id: I74842989784601325b6d8977da4bc936ceedbc0e (cherry picked from commit e9fd3bb13463f4a11f76694222dfc4f727c658b9)

MaysaMacedo commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gryf, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/master/OWNERS)~~ [MaysaMacedo,gryf] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dulek commented 2 years ago

/retest

Seem like just flaky tests.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci[bot] commented 2 years ago

@gryf: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
MaysaMacedo commented 2 years ago

/retitle Bug 2082075: Parallelize ports removal

openshift-ci[bot] commented 2 years ago

@gryf: All pull requests linked via external trackers have merged:

Bugzilla bug 2082075 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/655): >Bug 2082075: Parallelize ports removal Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 years ago

/cherry-pick release 4.10

openshift-cherrypick-robot commented 2 years ago

@MaysaMacedo: cannot checkout release 4.10: error checking out release 4.10: exit status 1. output: error: pathspec 'release 4.10' did not match any file(s) known to git

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/655#issuecomment-1118432497): >/cherry-pick release 4.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 years ago

/cherry-pick release-4.10

openshift-cherrypick-robot commented 2 years ago

@MaysaMacedo: new pull request created: #663

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/655#issuecomment-1118433140): >/cherry-pick release-4.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@MaysaMacedo: Bugzilla bug 2082075 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/655#issuecomment-1118438390): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.