search

openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #660

Closed ghost closed 2 years ago

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kuryr-bot To complete the pull request process, please assign maysamacedo after the PR has been reviewed. You can assign the PR to them by writing /assign @maysamacedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

Hi @kuryr-bot. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 years ago

@dulek should this one be a bug https://github.com/openshift/kuryr-kubernetes/pull/660/commits/ee3c26542f4e4d1c20b9a7bdd653bd62193c1622 ? Maybe this one should also be https://github.com/openshift/kuryr-kubernetes/pull/660/commits/d930d50392b8c0daad6d3a00f16714d6c8517337.

dulek commented 2 years ago

@dulek should this one be a bug ee3c265 ? Maybe this one should also be d930d50.

I'd say ee3c265 is really low impact and not worth the hassle of backporting and verification. d930d50 could be useful, but still hard to classify as a bug.