search

openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

Bug 2094801: Strip leading zeros from "funny" Service IPs #671

Closed dulek closed 2 years ago

dulek commented 2 years ago

According to [1] we're supposed to support "funny" Service IPs, which means IPs with leading zeros. Unlike unix in general we should not parse them as octal values, but rather treat them like without leading zeros. This commit makes sure that we strip the zeros from both ClusterIP and LoadBalancerIP before we put them into KuryrLoadBalancer struct. This means that later on Octavia and Neutron will get values that they support and will proceed with LB or FIP creation normally.

[1] https://github.com/kubernetes/kubernetes/blob/v1.24.1/test/e2e/network/funny_ips.go

openshift-ci[bot] commented 2 years ago

@dulek: This pull request references Bugzilla bug 2094801, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.11.0) matches configured target release for branch (4.11.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @eurijon

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/671): >Bug 2094801: Strip leading zeros from "funny" Service IPs Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gryf commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, gryf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/master/OWNERS)~~ [dulek,gryf] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 years ago

/retest-required

Remaining retests: 2 against base HEAD 629184366926b4a8b25463f860ffac3dddde5a2a and 8 for PR HEAD 0615ede8584bc925cd92267afdd422263ddfa8f4 in total

dulek commented 2 years ago

/hold

No need to retest until https://github.com/openshift/kuryr-kubernetes/pull/672 is merged.

MaysaMacedo commented 2 years ago

/retest

dulek commented 2 years ago

/hold cancel

MaysaMacedo commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

@dulek: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 2 years ago

@dulek: All pull requests linked via external trackers have merged:

Bugzilla bug 2094801 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/671): >Bug 2094801: Strip leading zeros from "funny" Service IPs Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.