search

openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

Bug 2094816: Do not crash on Neutron quota exceptions #675

Closed dulek closed 2 years ago

dulek commented 2 years ago

We shouldn't be failing on Neutron quota exceptions as Kuryr is not in a position to ever solve that by restarting. Anyway because bulk create method that we implemented raised a different exception, we failed to ignore them for health checks.

This commit makes sure bulk create method raises ConflictException, so that Retry handler will correctly handle it. Moreover the exception handling there is improved to make sure we're reading error code instead of error message.

openshift-ci[bot] commented 2 years ago

@dulek: This pull request references Bugzilla bug 2094816, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/675): >Bug 2094816: Do not crash on Neutron quota exceptions Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@dulek: This pull request references Bugzilla bug 2094816, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.11.0) matches configured target release for branch (4.11.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @eurijon

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/675#issuecomment-1163180241): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 years ago

/lgtm /retest

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/master/OWNERS)~~ [MaysaMacedo,dulek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 years ago

/retest-required

Remaining retests: 2 against base HEAD c4f89c9984c0810ea20dce8a7f11a80653458664 and 8 for PR HEAD 12ac3708504d0caee02cfbf8a0e029dd18e3b8d8 in total

openshift-ci-robot commented 2 years ago

/retest-required

Remaining retests: 1 against base HEAD c4f89c9984c0810ea20dce8a7f11a80653458664 and 7 for PR HEAD 12ac3708504d0caee02cfbf8a0e029dd18e3b8d8 in total

openshift-ci-robot commented 2 years ago

/retest-required

Remaining retests: 0 against base HEAD c4f89c9984c0810ea20dce8a7f11a80653458664 and 6 for PR HEAD 12ac3708504d0caee02cfbf8a0e029dd18e3b8d8 in total

dulek commented 2 years ago

/retest

MaysaMacedo commented 2 years ago

/override ci/prow/e2e-openstack-kuryr

openshift-ci[bot] commented 2 years ago

@MaysaMacedo: Overrode contexts on behalf of MaysaMacedo: ci/prow/e2e-openstack-kuryr

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/675#issuecomment-1164260620): >/override ci/prow/e2e-openstack-kuryr Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@dulek: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dulek commented 2 years ago

Seems like only an invariant is failing after both test suites finish. This isn't isolated to this patch, seems like something introduced by recent changes in openstack-tests.

openshift-ci[bot] commented 2 years ago

@dulek: All pull requests linked via external trackers have merged:

Bugzilla bug 2094816 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/675): >Bug 2094816: Do not crash on Neutron quota exceptions Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.