search

openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

DNM: Update minimum openstacksdk version to 0.59.0 #680

Closed dulek closed 2 years ago

dulek commented 2 years ago

This commit bumps openstacksdk to at least 0.59.0 in requirements.txt and removes the workarounds that we carried to actually support 0.36.0.

dulek commented 2 years ago

/hold

dulek commented 2 years ago

/retest

It's certainly not caused by this patch because Kuryr nor even cluster-network-operator haven't been deployed yet.

MaysaMacedo commented 2 years ago

clusteroperator/network is degraded because Deployment "/openshift-kuryr/kuryr-controller" rollout is not making progress - pod kuryr-controller-6786997c9d-86zz7 is in CrashLoopBackOff State

Looks like the must-gather didn't collect the appropriate logs because Kuryr was not happy. It might be worth accessing the cluster while installation is happening.

dulek commented 2 years ago

Ouch.

dulek commented 2 years ago

Okay, this should work better. I have troubles updating the upstream commit now, but let's see if this works.

dulek commented 2 years ago

/retest

Weird, but nothing alarming in Kuryr logs.

dulek commented 2 years ago

/retest

One more time.

openshift-ci[bot] commented 2 years ago

@dulek: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
gryf commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, gryf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/master/OWNERS)~~ [dulek,gryf] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dulek commented 2 years ago

This is on hold and let's keep it. I'd rather merge this once the patch is in upstream too.