openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

Adapt to use PyPi for builds instead of RPMs #682

Closed dulek closed 1 year ago

dulek commented 2 years ago

Main problem with RPMs is that we need to use OSP ones and these are super outdated. ART recently figured out how to enable builds based on PyPi packages going through ARTs Cachito instance. This will let us skip all the RPM hell that we have today and this commit aims to do that. In particular:

  1. kuryr-requirements.txt file is added that will gather exact versions of packages that we want from PyPi.
  2. Dockerfiles are adapted to install Kuryr as a Python package and not an RPM.
  3. Stuff required to build Kuryr RPM is removed as it's no needed anymore.
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/master/OWNERS)~~ [dulek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dulek commented 2 years ago

/hold

This is strongly WiP!

dulek commented 2 years ago

/retest

That's just a failure to acquire the lease.

openshift-ci[bot] commented 2 years ago

@dulek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images d0b35b63100b04b714d3405b0ea5d1f976cef3ee link true /test images
ci/prow/e2e-openstack-kuryr d0b35b63100b04b714d3405b0ea5d1f976cef3ee link true /test e2e-openstack-kuryr

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 1 year ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

dulek commented 1 year ago

We might want to revisit this at some point, but right now it's not a priority.