Merge https://opendev.org/openstack/kuryr-kubernetes:master into master

[openshift-ci[bot]]

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[dulek]

/ok-to-test

[dulek]

/retest

Some flakes, it seems.

[dulek]

/retest

Just a lease acquiring failure.

[MaysaMacedo]

There is an issue with Ports deletion, I'm working on a fix:

2022-07-28T11:52:08.884132669Z 2022-07-28 11:52:08.883 1 ERROR kuryr_kubernetes.handlers.logging   File "/usr/lib/python3.6/site-packages/kuryr_kubernetes/controller/drivers/utils.py", line 696, in delete_port
2022-07-28T11:52:08.884132669Z 2022-07-28 11:52:08.883 1 ERROR kuryr_kubernetes.handlers.logging     os_net.delete_port(leftover_port.id)
2022-07-28T11:52:08.884132669Z 2022-07-28 11:52:08.883 1 ERROR kuryr_kubernetes.handlers.logging AttributeError: 'str' object has no attribute 'id'

[MaysaMacedo]

https://review.opendev.org/c/openstack/kuryr-kubernetes/+/851328

[dulek]

@MaysaMacedo, this now has the fix, right?

[MaysaMacedo]

@MaysaMacedo, this now has the fix, right?

yes.

[MaysaMacedo]

Looks like we could reduce the logging to debug on this one as well (I'm fine with merging as is, we can include later):

2022-08-05T10:09:11.520541696Z 2022-08-05 10:09:11.517 1 ERROR kuryr_kubernetes.controller.handlers.namespace   File "/usr/lib/python3.6/site-packages/kuryr_kubernetes/controller/handlers/namespace.py", line 126, in _add_kuryrnetwork_crd
2022-08-05T10:09:11.520541696Z 2022-08-05 10:09:11.517 1 ERROR kuryr_kubernetes.controller.handlers.namespace     constants.K8S_API_CRD_NAMESPACES, ns_name), kns_crd)
2022-08-05T10:09:11.520541696Z 2022-08-05 10:09:11.517 1 ERROR kuryr_kubernetes.controller.handlers.namespace   File "/usr/lib/python3.6/site-packages/kuryr_kubernetes/k8s_client.py", line 207, in post
2022-08-05T10:09:11.520541696Z 2022-08-05 10:09:11.517 1 ERROR kuryr_kubernetes.controller.handlers.namespace     self._raise_from_response(response)
2022-08-05T10:09:11.520541696Z 2022-08-05 10:09:11.517 1 ERROR kuryr_kubernetes.controller.handlers.namespace   File "/usr/lib/python3.6/site-packages/kuryr_kubernetes/k8s_client.py", line 104, in _raise_from_response
2022-08-05T10:09:11.520541696Z 2022-08-05 10:09:11.517 1 ERROR kuryr_kubernetes.controller.handlers.namespace     raise exc.K8sNamespaceTerminating(response.text)
2022-08-05T10:09:11.520541696Z 2022-08-05 10:09:11.517 1 ERROR kuryr_kubernetes.controller.handlers.namespace kuryr_kubernetes.exceptions.K8sNamespaceTerminating: Forbidden: 'Namespace already terminated: \'{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"kuryrnetworks.openstack.org \\\\"e2e-svcaccounts-345\\\\" is forbidden: unable to create new content in namespace e2e-svcaccounts-345 because it is being terminated","reason":"Forbidden","details":{"name":"e2e-svcaccounts-345","group":"openstack.org","kind":"kuryrnetworks","causes":[{"reason":"NamespaceTerminating","message":"namespace e2e-svcaccounts-345 is being terminated","field":"metadata.namespace"}]},"code":403}\\n\''

[MaysaMacedo]

/retest /lgtm

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaysaMacedo, shiftstack-merge-bot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/master/OWNERS)~~ [MaysaMacedo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD 51d62c40b1229e6764401e85abf531b7aea08dd9 and 8 for PR HEAD c637b2086e12c3cc61305653d8714cf7fd751bfc in total

[openshift-ci-robot]

/retest-required

Remaining retests: 1 against base HEAD 51d62c40b1229e6764401e85abf531b7aea08dd9 and 7 for PR HEAD c637b2086e12c3cc61305653d8714cf7fd751bfc in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 51d62c40b1229e6764401e85abf531b7aea08dd9 and 6 for PR HEAD c637b2086e12c3cc61305653d8714cf7fd751bfc in total

[openshift-ci[bot]]

@shiftstack-merge-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).