search

openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

Bug OCPBUGS-577: Fix unbound router_id variable while creating event #687

Closed MaysaMacedo closed 2 years ago

MaysaMacedo commented 2 years ago

If there was any SDK exception while adding Subnet to the Router e.g. 504 Gateway Time-out, no router_id would be returned causing the Kuryr controller to restart when trying to create an event with the unbound variable router_id. This commit fixes the issue by removing the variable.

Change-Id: Ib26fce6ccdc83c61821b54297a388d0acd2da2c7

openshift-ci[bot] commented 2 years ago

@MaysaMacedo: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687): >Fix unbound router_id variable while creating event Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gryf commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gryf, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/release-4.11/OWNERS)~~ [MaysaMacedo,gryf] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dulek commented 2 years ago

/override ci/prow/e2e-openstack-kuryr /label backport-risk-assessed

No need to run CI for such a safe change.

openshift-ci[bot] commented 2 years ago

@dulek: Overrode contexts on behalf of dulek: ci/prow/e2e-openstack-kuryr

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687#issuecomment-1226893732): >/override ci/prow/e2e-openstack-kuryr >/label backport-risk-assessed > >No need to run CI for such a safe change. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@MaysaMacedo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-kuryr fe2418b9a48bc32e487fa29523c56c21da150087 link true /test e2e-openstack-kuryr

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
MaysaMacedo commented 2 years ago

/retitle Bug OSASINFRA-2977: Fix unbound router_id variable while creating event

openshift-ci[bot] commented 2 years ago

@MaysaMacedo: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687): >Bug [OSASINFRA-2977](https://issues.redhat.com//browse/OSASINFRA-2977): Fix unbound router_id variable while creating event Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 years ago

/retitle Bug OCPBUGS-576: Fix unbound router_id variable while creating event

openshift-ci-robot commented 2 years ago

@MaysaMacedo: This pull request references Jira Issue [OCPBUGS-576](https://issues.redhat.com//browse/OCPBUGS-576), which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687): >If there was any SDK exception while adding Subnet to the Router >e.g. 504 Gateway Time-out, no router_id would be returned causing >the Kuryr controller to restart when trying to create an event with >the unbound variable router_id. This commit fixes the issue by >removing the variable. > >Change-Id: Ib26fce6ccdc83c61821b54297a388d0acd2da2c7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@MaysaMacedo: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687): >Bug [OCPBUGS-576](https://issues.redhat.com//browse/OCPBUGS-576): Fix unbound router_id variable while creating event Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@MaysaMacedo: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687#issuecomment-1226967083): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 years ago

@MaysaMacedo: This pull request references Jira Issue [OCPBUGS-577](https://issues.redhat.com//browse/OCPBUGS-577), which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687): >If there was any SDK exception while adding Subnet to the Router >e.g. 504 Gateway Time-out, no router_id would be returned causing >the Kuryr controller to restart when trying to create an event with >the unbound variable router_id. This commit fixes the issue by >removing the variable. > >Change-Id: Ib26fce6ccdc83c61821b54297a388d0acd2da2c7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@MaysaMacedo: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687): >Bug [OCPBUGS-577](https://issues.redhat.com//browse/OCPBUGS-577): Fix unbound router_id variable while creating event Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@MaysaMacedo: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687#issuecomment-1226975869): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 years ago

/jira refresh

openshift-ci-robot commented 2 years ago

@MaysaMacedo: This pull request references Jira Issue [OCPBUGS-577](https://issues.redhat.com//browse/OCPBUGS-577), which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687#issuecomment-1226976224): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 years ago

/jira refresh

openshift-ci-robot commented 2 years ago

@MaysaMacedo: This pull request references Jira Issue [OCPBUGS-577](https://issues.redhat.com//browse/OCPBUGS-577), which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687#issuecomment-1226993490): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 years ago

/jira refresh /cc @eurijon for the cherry-pick label

openshift-ci-robot commented 2 years ago

@MaysaMacedo: This pull request references Jira Issue [OCPBUGS-577](https://issues.redhat.com//browse/OCPBUGS-577), which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.11.z) matches configured target version for branch (4.11.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST) * dependent bug [Jira Issue [OCPBUGS-576](https://issues.redhat.com//browse/OCPBUGS-576)](https://issues.redhat.com//browse/OCPBUGS-576) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue [OCPBUGS-576](https://issues.redhat.com//browse/OCPBUGS-576)](https://issues.redhat.com//browse/OCPBUGS-576) targets the "4.12.0" version, which is one of the valid target versions: 4.12.0 * bug has dependents
In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687#issuecomment-1226994931): >/jira refresh >/cc @eurijon for the cherry-pick label Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@MaysaMacedo: GitHub didn't allow me to request PR reviews from the following users: for, the, cherry-pick, label.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687#issuecomment-1226994931): >/jira refresh >/cc @eurijon for the cherry-pick label Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
eurijon commented 2 years ago

/label cherry-pick-approved

openshift-ci-robot commented 2 years ago

@MaysaMacedo: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-577 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687): >If there was any SDK exception while adding Subnet to the Router >e.g. 504 Gateway Time-out, no router_id would be returned causing >the Kuryr controller to restart when trying to create an event with >the unbound variable router_id. This commit fixes the issue by >removing the variable. > >Change-Id: Ib26fce6ccdc83c61821b54297a388d0acd2da2c7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 years ago

/cherry-pick release-4.10

openshift-cherrypick-robot commented 2 years ago

@MaysaMacedo: new pull request created: #688

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/687#issuecomment-1238000604): >/cherry-pick release-4.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.