search

openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

[release-4.11] Bug OCPBUGS-1713: Cleanup KuryrPort when Pod is missing #694

Closed openshift-cherrypick-robot closed 1 year ago

openshift-cherrypick-robot commented 1 year ago

This is an automated cherry-pick of #691

/assign dulek

openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-198 has been cloned as Jira Issue OCPBUGS-1713. Retitling PR to link against new bug. /retitle [release-4.11] Bug OCPBUGS-1713: Cleanup KuryrPort when Pod is missing

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/694): >This is an automated cherry-pick of #691 > >/assign dulek Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-1713, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/694): >This is an automated cherry-pick of #691 > >/assign dulek Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/694): >[release-4.11] Bug OCPBUGS-1713: Cleanup KuryrPort when Pod is missing Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@dulek: This pull request references Jira Issue OCPBUGS-1713, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.11.z) matches configured target version for branch (4.11.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-198](https://issues.redhat.com//browse/OCPBUGS-198) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE)) * dependent [Jira Issue OCPBUGS-198](https://issues.redhat.com//browse/OCPBUGS-198) targets the "4.12.0" version, which is one of the valid target versions: 4.12.0 * bug has dependents

Requesting review from QA contact: /cc @eurijon

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/694#issuecomment-1263548710): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 1 year ago

/lgtm /approve /override ci/prow/e2e-openstack-kuryr

It's all good, only the expected test fails.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/release-4.11/OWNERS)~~ [dulek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@dulek: Overrode contexts on behalf of dulek: ci/prow/e2e-openstack-kuryr

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/694#issuecomment-1263549958): >/lgtm >/approve >/override ci/prow/e2e-openstack-kuryr > >It's all good, only the expected test fails. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dulek commented 1 year ago

/label backport-risk-assessed

dulek commented 1 year ago

@eurijon, I think this is good to go.

eurijon commented 1 year ago

/label cherry-pick-approved

openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1713 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/694): >This is an automated cherry-pick of #691 > >/assign dulek Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 1 year ago

/chery-pick release-4.10

dulek commented 1 year ago

/cherry-pick release-4.10

openshift-cherrypick-robot commented 1 year ago

@dulek: #694 failed to apply on top of branch "release-4.10":

Applying: Cleanup KuryrPort when Pod is missing
Using index info to reconstruct a base tree...
M   kuryr_kubernetes/controller/drivers/vif_pool.py
M   kuryr_kubernetes/controller/handlers/kuryrport.py
M   kuryr_kubernetes/tests/unit/controller/drivers/test_vif_pool.py
M   kuryr_kubernetes/tests/unit/test_utils.py
M   kuryr_kubernetes/utils.py
Falling back to patching base and 3-way merge...
Auto-merging kuryr_kubernetes/utils.py
CONFLICT (content): Merge conflict in kuryr_kubernetes/utils.py
Auto-merging kuryr_kubernetes/tests/unit/test_utils.py
CONFLICT (content): Merge conflict in kuryr_kubernetes/tests/unit/test_utils.py
Auto-merging kuryr_kubernetes/tests/unit/controller/drivers/test_vif_pool.py
Auto-merging kuryr_kubernetes/controller/handlers/kuryrport.py
Auto-merging kuryr_kubernetes/controller/drivers/vif_pool.py
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Cleanup KuryrPort when Pod is missing
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/694#issuecomment-1273118134): >/cherry-pick release-4.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 year ago

[ART PR BUILD NOTIFIER]

This PR has been included in build kuryr-cni-container-v4.11.0-202305020028.p0.g93daed6.assembly.stream for distgit kuryr-cni. All builds following this will include this PR.

openshift-bot commented 1 year ago

[ART PR BUILD NOTIFIER]

This PR has been included in build kuryr-controller-container-v4.11.0-202305020028.p0.g93daed6.assembly.stream for distgit kuryr-controller. All builds following this will include this PR.