search

openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

OCPBUGS-11993: Fix VIF revert on KuryrPort status update error #721

Closed dulek closed 1 year ago

dulek commented 1 year ago

There's argument number mismatch on release_vif() call while reverting port association. This commit fixes that.

openshift-ci-robot commented 1 year ago

@dulek: This pull request references Jira Issue OCPBUGS-11993, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/721): >There's argument number mismatch on release_vif() call while reverting port association. This commit fixes that. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 1 year ago

/jira refresh

openshift-ci[bot] commented 1 year ago

@dulek: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/721): >OCPBUGS-11993: Fix VIF revert on KuryrPort status update error Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@dulek: This pull request references Jira Issue OCPBUGS-11993, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/721): >There's argument number mismatch on release_vif() call while reverting port association. This commit fixes that. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@dulek: This pull request references Jira Issue OCPBUGS-11993, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/721#issuecomment-1514863948): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@dulek: This pull request references Jira Issue OCPBUGS-11993, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/721#issuecomment-1514871278): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@dulek: This pull request references Jira Issue OCPBUGS-11993, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.z) matches configured target version for branch (4.12.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-11994](https://issues.redhat.com//browse/OCPBUGS-11994) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE)) * dependent [Jira Issue OCPBUGS-11994](https://issues.redhat.com//browse/OCPBUGS-11994) targets the "4.13.0" version, which is one of the valid target versions: 4.13.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/721#issuecomment-1514872273): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 1 year ago

/cherry-pick release-4.11

openshift-cherrypick-robot commented 1 year ago

@dulek: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/721#issuecomment-1514890764): >/cherry-pick release-4.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 1 year ago

/retest

dulek commented 1 year ago

/retest

dulek commented 1 year ago

/retest

dulek commented 1 year ago

/retest

dulek commented 1 year ago

/label backport-risk-assessed

dulek commented 1 year ago

/retest

dulek commented 1 year ago

/retest

dulek commented 1 year ago

Seems like we have some troubles with Octavia at the Kuryr cloud, overriding. /override ci/prow/e2e-openstack-kuryr

dulek commented 1 year ago

/cc @MaysaMacedo

openshift-ci[bot] commented 1 year ago

@dulek: Overrode contexts on behalf of dulek: ci/prow/e2e-openstack-kuryr

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/721#issuecomment-1525226475): >Seems like we have some troubles with Octavia at the Kuryr cloud, overriding. >/override ci/prow/e2e-openstack-kuryr Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@dulek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-kuryr d3e6b649968e572ad0bc8637a702df36fec02a1e link true /test e2e-openstack-kuryr

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
MaysaMacedo commented 1 year ago

/lgtm /label cherry-pick-approved

openshift-ci[bot] commented 1 year ago

@MaysaMacedo: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/721#issuecomment-1525244742): >/lgtm >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 1 year ago

/cc @rlobillo can you check this pr and try applying the cherry-pick-approved label if you see fit?

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/release-4.12/OWNERS)~~ [MaysaMacedo,dulek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rlobillo commented 1 year ago

/label cherry-pick-approved

As stated at the clone in 4.13 https://issues.redhat.com/browse/OCPBUGS-11994, QE verification is not needed for this.

openshift-ci-robot commented 1 year ago

@dulek: Jira Issue OCPBUGS-11993: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11993 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/721): >There's argument number mismatch on release_vif() call while reverting port association. This commit fixes that. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 year ago

@dulek: new pull request created: #725

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/721#issuecomment-1514890764): >/cherry-pick release-4.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 year ago

[ART PR BUILD NOTIFIER]

This PR has been included in build kuryr-controller-container-v4.12.0-202305022015.p0.g3e5ab43.assembly.stream for distgit kuryr-controller. All builds following this will include this PR.

openshift-bot commented 1 year ago

[ART PR BUILD NOTIFIER]

This PR has been included in build kuryr-cni-container-v4.12.0-202305022015.p0.g3e5ab43.assembly.stream for distgit kuryr-cni. All builds following this will include this PR.

openshift-bot commented 1 year ago

[ART PR BUILD NOTIFIER]

This PR has been included in build kuryr-controller-container-v4.12.0-202305030754.p0.g3e5ab43.assembly.stream for distgit kuryr-controller. All builds following this will include this PR.

openshift-bot commented 1 year ago

[ART PR BUILD NOTIFIER]

This PR has been included in build kuryr-cni-container-v4.12.0-202305030754.p0.g3e5ab43.assembly.stream for distgit kuryr-cni. All builds following this will include this PR.