openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

Updating kuryr-cni images to be consistent with ART #723

Closed openshift-bot closed 1 year ago

openshift-bot commented 1 year ago

Updating kuryr-cni images to be consistent with ART TLDR: Component owners, please ensure that this PR merges as it impacts the fidelity of your CI signal. Patch-manager / leads, this PR is a no-op from a product perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test to remove this tag and help the PR to merge.

Detail: This repository is out of sync with the downstream product builds for this component. One or more images differ from those being used by ART to create product builds. This should be addressed to ensure that the component's CI testing is accurately reflecting what customers will experience.

The information within the following ART component metadata is driving this alignment request: kuryr-cni.yml.

The vast majority of these PRs are opened because a different Golang version is being used to build the downstream component. ART compiles most components with the version of Golang being used by the control plane for a given OpenShift release. Exceptions to this convention (i.e. you believe your component must be compiled with a Golang version independent from the control plane) must be granted by the OpenShift architecture team and communicated to the ART team.

Roles & Responsibilities:

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
  from_repository: true

If you have any questions about this pull request, please reach out to @release-artists in the #aos-art coreos slack channel.

MaysaMacedo commented 1 year ago

/lgtm /approve /retest

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaysaMacedo, openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/master/OWNERS)~~ [MaysaMacedo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 year ago

/retest-required

Remaining retests: 0 against base HEAD 686762c1f5c566de4ed051ed53ccaa64d6268bc7 and 2 for PR HEAD 7cd76322041c10d2abeb757ae00fbd9c13214daf in total

openshift-ci-robot commented 1 year ago

/retest-required

Remaining retests: 0 against base HEAD 696bcd08e186c365bd9bed871f29877b69ac1079 and 1 for PR HEAD 7cd76322041c10d2abeb757ae00fbd9c13214daf in total

openshift-ci[bot] commented 1 year ago

@openshift-bot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).