search

openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

[release-4.11] OCPBUGS-12840: Fix VIF revert on KuryrPort status update error #725

Closed openshift-cherrypick-robot closed 1 year ago

openshift-cherrypick-robot commented 1 year ago

This is an automated cherry-pick of #721

/assign dulek

openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-11993 has been cloned as Jira Issue OCPBUGS-12840. Will retitle bug to link to clone. /retitle [release-4.11] OCPBUGS-12840: Fix VIF revert on KuryrPort status update error

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/725): >This is an automated cherry-pick of #721 > >/assign dulek Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/725): >[release-4.11] OCPBUGS-12840: Fix VIF revert on KuryrPort status update error Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-12840, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/725): >This is an automated cherry-pick of #721 > >/assign dulek Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@dulek: This pull request references Jira Issue OCPBUGS-12840, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.11.z) matches configured target version for branch (4.11.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-11993](https://issues.redhat.com//browse/OCPBUGS-11993) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE)) * dependent [Jira Issue OCPBUGS-11993](https://issues.redhat.com//browse/OCPBUGS-11993) targets the "4.12.z" version, which is one of the valid target versions: 4.12.0, 4.12.z * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/725#issuecomment-1525878652): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 1 year ago

I needed to add fix to one more occurrence of the problem, that's where the force-push comes from.

dulek commented 1 year ago

/label backport-risk-assessed

dulek commented 1 year ago

/retest

openshift-ci[bot] commented 1 year ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
MaysaMacedo commented 1 year ago

/lgtm /approve /cherry-pick-approved

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaysaMacedo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/release-4.11/OWNERS)~~ [MaysaMacedo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MaysaMacedo commented 1 year ago

/label cherry-pick-approved

openshift-ci[bot] commented 1 year ago

@MaysaMacedo: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/725#issuecomment-1539684632): >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 1 year ago

@itzikb-redhat can you check the cherry-pick-approved label in this PR?

itzikb-redhat commented 1 year ago

/label cherry-pick-approved

openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-12840: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-12840 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/725): >This is an automated cherry-pick of #721 > >/assign dulek Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-merge-robot commented 1 year ago

Fix included in accepted release 4.11.0-0.nightly-2023-05-11-143305