search

openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

OCPBUGS-15239: Remove unneeded grpcio dependencies from RPM #734

Closed dulek closed 1 year ago

dulek commented 1 year ago

Since the removal of SR-IOV code grpcio and protobuf are not needed as dependencies. We forgot to remove them from the RPM spec and this commit fixes that.

openshift-ci-robot commented 1 year ago

@dulek: This pull request references Jira Issue OCPBUGS-15239, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/734): >Since the removal of SR-IOV code grpcio and protobuf are not needed as >dependencies. We forgot to remove them from the RPM spec and this commit >fixes that. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@dulek: This pull request references Jira Issue OCPBUGS-15239, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/734#issuecomment-1600421924): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@dulek: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dulek commented 1 year ago

/cc @MaysaMacedo

MaysaMacedo commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/master/OWNERS)~~ [MaysaMacedo,dulek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 year ago

@dulek: Jira Issue OCPBUGS-15239: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15239 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/734): >Since the removal of SR-IOV code grpcio and protobuf are not needed as >dependencies. We forgot to remove them from the RPM spec and this commit >fixes that. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 1 year ago

I checked that this works.

/cherry-pick release-4.13

openshift-cherrypick-robot commented 1 year ago

@dulek: new pull request created: #735

In response to [this](https://github.com/openshift/kuryr-kubernetes/pull/734#issuecomment-1609249780): >I checked that this works. > >/cherry-pick release-4.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.