search

openshift / kuryr-kubernetes

kuryr-kubernetes - CNI plugin using OpenStack Neutron and Octavia to provide networking for pods and services.
Apache License 2.0
21 stars 23 forks source link

WiP: Protect from Neutron issues #744

Closed dulek closed 11 months ago

dulek commented 1 year ago

Seems like Neutron can return pretty wild data sometimes. This commit makes sure we're protected from ports that doesn't have any address.

Change-Id: Ie2bce807ab4911e40cda34b42099f2e8a1c2aeba

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/kuryr-kubernetes/blob/master/OWNERS)~~ [dulek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MaysaMacedo commented 1 year ago

@dulek did you see tracebacks indicating this issue? Is it worth to fix upstream?

dulek commented 1 year ago

@dulek did you see tracebacks indicating this issue? Is it worth to fix upstream?

Yes, I've seen them. I'm experimenting here a bit, will fix upstream-first once I have it figured out.

dulek commented 1 year ago

/hold

openshift-ci[bot] commented 1 year ago

@dulek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-kuryr 95ef7317452a3422b315767389beb57fad5a50d3 link true /test e2e-openstack-kuryr
ci/prow/unit 95ef7317452a3422b315767389beb57fad5a50d3 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dulek commented 11 months ago

Kuryr is EOL in OpenShift.