openshift / library-go

Helpers for going from apis and clients to useful runtime constructs
Apache License 2.0
94 stars 226 forks source link

OCPBUGS-36233: Replicas hook consider Control plane topology #1810

Closed dfajmon closed 2 weeks ago

dfajmon commented 3 weeks ago

If ControlPlaneTopology is set to HighlyAvailable return pod count 2 else 1.

backporting from #1796

openshift-ci-robot commented 3 weeks ago

@dfajmon: This pull request references Jira Issue OCPBUGS-36233, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/library-go/pull/1810): >If ControlPlaneTopology is set to `HighlyAvailable` return pod count 2 else 1. > >backporting from #1796 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 weeks ago

@dfajmon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
RomanBednar commented 2 weeks ago

/lgtm /approve

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dfajmon, RomanBednar Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/operator/csi/OWNERS](https://github.com/openshift/library-go/blob/release-4.16/pkg/operator/csi/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dfajmon commented 2 weeks ago

/hold discussing if we really need backport for this

dfajmon commented 2 weeks ago

/close no backport needed

openshift-ci[bot] commented 2 weeks ago

@dfajmon: Closed this PR.

In response to [this](https://github.com/openshift/library-go/pull/1810#issuecomment-2393821492): >/close >no backport needed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 weeks ago

@dfajmon: This pull request references Jira Issue OCPBUGS-36233. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/library-go/pull/1810): >If ControlPlaneTopology is set to `HighlyAvailable` return pod count 2 else 1. > >backporting from #1796 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.