search

openshift / library-go

Helpers for going from apis and clients to useful runtime constructs
Apache License 2.0
94 stars 226 forks source link

API-1835: fix initialization of variable in deployment controller #1812

Closed bertinatto closed 3 weeks ago

bertinatto commented 3 weeks ago

Failure:

{Operator degraded (GCPPDCSIDriverOperatorCR_GCPPDDriverControllerServiceController_SyncError): GCPPDCSIDriverOperatorCRDegraded: GCPPDDriverControllerServiceControllerDegraded: unable to ApplyStatus for operator using fieldManager "": PatchOptions.meta.k8s.io "" is invalid: fieldManager: Required value: is required for apply patch  Operator degraded (GCPPDCSIDriverOperatorCR_GCPPDDriverControllerServiceController_SyncError): GCPPDCSIDriverOperatorCRDegraded: GCPPDDriverControllerServiceControllerDegraded: unable to ApplyStatus for operator using fieldManager "": PatchOptions.meta.k8s.io "" is invalid: fieldManager: Required value: is required for apply patch}

xref: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_gcp-pd-csi-driver-operator/127/pull-ci-openshift-gcp-pd-csi-driver-operator-master-e2e-gcp-csi/1840730610318970880

Introduced in https://github.com/openshift/library-go/pull/1794/files#diff-abb679a52a6ea86c466b84d87793ee37682c0e4b6a111234e69cb684d7ec3157.

/assign @deads2k @p0lyn0mial

openshift-ci-robot commented 3 weeks ago

@bertinatto: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/library-go/pull/1812): >Failure: > >``` >{Operator degraded (GCPPDCSIDriverOperatorCR_GCPPDDriverControllerServiceController_SyncError): GCPPDCSIDriverOperatorCRDegraded: GCPPDDriverControllerServiceControllerDegraded: unable to ApplyStatus for operator using fieldManager "": PatchOptions.meta.k8s.io "" is invalid: fieldManager: Required value: is required for apply patch Operator degraded (GCPPDCSIDriverOperatorCR_GCPPDDriverControllerServiceController_SyncError): GCPPDCSIDriverOperatorCRDegraded: GCPPDDriverControllerServiceControllerDegraded: unable to ApplyStatus for operator using fieldManager "": PatchOptions.meta.k8s.io "" is invalid: fieldManager: Required value: is required for apply patch} >``` > >xref: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_gcp-pd-csi-driver-operator/127/pull-ci-openshift-gcp-pd-csi-driver-operator-master-e2e-gcp-csi/1840730610318970880 > >Introduced in https://github.com/openshift/library-go/pull/1794/files#diff-abb679a52a6ea86c466b84d87793ee37682c0e4b6a111234e69cb684d7ec3157. > >/assign @deads2k @p0lyn0mial Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
bertinatto commented 3 weeks ago

/hold proof: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_gcp-pd-csi-driver-operator/127/pull-ci-openshift-gcp-pd-csi-driver-operator-master-e2e-gcp-csi/1840793937418129408

openshift-ci[bot] commented 3 weeks ago

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
deads2k commented 3 weeks ago

/lgtm /approve

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/operator/OWNERS](https://github.com/openshift/library-go/blob/master/pkg/operator/OWNERS)~~ [bertinatto,deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deads2k commented 3 weeks ago

/hold cancel