search

openshift / library-go

Helpers for going from apis and clients to useful runtime constructs
Apache License 2.0
94 stars 226 forks source link

API-1835: Update the static pod state controller to use Apply #1816

Closed p0lyn0mial closed 2 weeks ago

p0lyn0mial commented 3 weeks ago

proof pr at https://github.com/openshift/cluster-kube-apiserver-operator/pull/1749

openshift-ci-robot commented 3 weeks ago

@p0lyn0mial: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/library-go/pull/1816): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
p0lyn0mial commented 3 weeks ago

/hold

holding off for a proof pr.

deads2k commented 3 weeks ago

Lgtm. But needs to pass tests

p0lyn0mial commented 3 weeks ago

/test unit

deads2k commented 3 weeks ago

/lgtm

openshift-ci-robot commented 2 weeks ago

@p0lyn0mial: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/library-go/pull/1816): >proof pr at https://github.com/openshift/cluster-kube-apiserver-operator/pull/1749 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
p0lyn0mial commented 2 weeks ago

ok, the StaticPodsDegraded condition was properly updated in . this pr can be safely merged.

p0lyn0mial commented 2 weeks ago

/hold cancel

deads2k commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/operator/staticpod/OWNERS](https://github.com/openshift/library-go/blob/master/pkg/operator/staticpod/OWNERS)~~ [deads2k,p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).