search

openshift / library-go

Helpers for going from apis and clients to useful runtime constructs
Apache License 2.0
94 stars 226 forks source link

Add test-e2e-monitoring placeholder rule #1829

Closed dgrisonnet closed 1 week ago

dgrisonnet commented 1 week ago

Add a placeholder Makefile rule to test https://github.com/openshift/release/pull/57664 before adding the actual test in https://github.com/openshift/library-go/pull/1823.

p0lyn0mial commented 1 week ago

/lgtm

/assign @bertinatto for approval

openshift-ci[bot] commented 1 week ago

@dgrisonnet: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, dgrisonnet, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/library-go/blob/master/OWNERS)~~ [bertinatto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment