search

openshift / library-go

Helpers for going from apis and clients to useful runtime constructs
Apache License 2.0
94 stars 226 forks source link

enhancement: drop the redundant `ApplyUnstructuredResourceImproved` return value #1833

Open rexagod opened 1 week ago

rexagod commented 1 week ago

Drop the boolean return value that signified if an update happened as it is not necessary and pollutes the signature.

Signed-off-by: Pranshu Srivastava rexagod@gmail.com

Blocked by (and rebased over) https://github.com/openshift/library-go/pull/1823. The relevant commit is https://github.com/openshift/library-go/pull/1833/commits/12f2bce9c9c28af97c00861845613ae2d3f0622d.

rexagod commented 1 week ago

(cc @jan--f)

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rexagod Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/operator/OWNERS](https://github.com/openshift/library-go/blob/master/pkg/operator/OWNERS)** - **[test/e2e-monitoring/OWNERS](https://github.com/openshift/library-go/blob/master/test/e2e-monitoring/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 days ago

@rexagod: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).