search

openshift / library-go

Helpers for going from apis and clients to useful runtime constructs
Apache License 2.0
94 stars 226 forks source link

add p0lyn0mial to OWNERS #1837

Closed p0lyn0mial closed 1 week ago

p0lyn0mial commented 1 week ago

/assign @bertinatto @deads2k

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/library-go/blob/master/OWNERS)~~ [bertinatto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 week ago

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
deads2k commented 1 week ago

Dropping a comment here so we link back to it.

remember that

  1. you're the reviewer of last resort, so you may have to learn something pretty quickly
  2. it's important to say "no" to things that don't have generic purpose that will force people to use the "one" copy. Many helpers seem useful, but in practice never gain adoption
  3. keep the dep tree small because diamond dependencies from this repo are awful. it's especially important to avoid vendoring APIs because they depend on alternative levels of k8s.io/apimachinery that can conflict in ways that prevent kube updates from landing.