search

openshift / library-go

Helpers for going from apis and clients to useful runtime constructs
Apache License 2.0
94 stars 226 forks source link

OCPBUGS-43509: add resourceread functions for ValidatingAdmissionPolicyV1 #1843

Closed djoshy closed 2 days ago

djoshy commented 6 days ago

This is required for the MCO to use ValidatingAdmissionPolicyV1. We currently use ValidatingAdmissionPolicyV1Beta1 which has been deprecated.

openshift-ci-robot commented 6 days ago

@djoshy: This pull request references Jira Issue OCPBUGS-43509, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/library-go/pull/1843): >This is required for the [MCO to use ValidatingAdmissionPolicyV1](https://issues.redhat.com/browse/OCPBUGS-43509). We currently use ValidatingAdmissionPolicyV1Beta1 which has been deprecated. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dusk125 commented 3 days ago

/lgtm

openshift-ci[bot] commented 2 days ago

@djoshy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
p0lyn0mial commented 2 days ago

/lgtm

openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, dusk125, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/operator/OWNERS](https://github.com/openshift/library-go/blob/master/pkg/operator/OWNERS)~~ [p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 days ago

@djoshy: Jira Issue OCPBUGS-43509: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43509 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/library-go/pull/1843): >This is required for the [MCO to use ValidatingAdmissionPolicyV1](https://issues.redhat.com/browse/OCPBUGS-43509). We currently use ValidatingAdmissionPolicyV1Beta1 which has been deprecated. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.