openshift / library-go

Helpers for going from apis and clients to useful runtime constructs
Apache License 2.0
94 stars 226 forks source link

NO-JIRA: node_controller: change newTargetNodeState assignment and rename to triggerStatusApplyError #1844

Closed p0lyn0mial closed 6 days ago

p0lyn0mial commented 6 days ago

@bertinatto IOUs from https://github.com/openshift/library-go/pull/1821

openshift-ci-robot commented 6 days ago

@p0lyn0mial: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/library-go/pull/1844): >@bertinatto IOUs from https://github.com/openshift/library-go/pull/1821 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
deads2k commented 6 days ago

/lgtm /approve

openshift-ci[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/operator/staticpod/OWNERS](https://github.com/openshift/library-go/blob/master/pkg/operator/staticpod/OWNERS)~~ [deads2k,p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 6 days ago

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).