search

openshift / library-go

Helpers for going from apis and clients to useful runtime constructs
Apache License 2.0
94 stars 226 forks source link

API-1835: Migrate multiple controllers to SSA #1853

Open bertinatto opened 1 day ago

bertinatto commented 1 day ago

Better reviewed commit by commit.

Proof: https://github.com/openshift/cluster-authentication-operator/pull/721

Verb usage comparison between single-node jobs from proof and https://github.com/openshift/cluster-authentication-operator/pull/715:

verb_usage_comparison_auth

openshift-ci-robot commented 1 day ago

@bertinatto: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/library-go/pull/1853): >Better reviewed commit by commit. > >Proof: https://github.com/openshift/cluster-authentication-operator/pull/721 > >/hold Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/operator/OWNERS](https://github.com/openshift/library-go/blob/master/pkg/operator/OWNERS)~~ [bertinatto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 day ago

@bertinatto: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/library-go/pull/1853): >Better reviewed commit by commit. > >Proof: https://github.com/openshift/cluster-authentication-operator/pull/721 > >Verb usage comparison between single-node jobs from proof and https://github.com/openshift/cluster-authentication-operator/pull/715: > >![verb_usage_comparison_auth](https://github.com/user-attachments/assets/edb6b8f1-a5b6-4078-ae2f-25acb8f104e6) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
bertinatto commented 1 day ago

/hold cancel

openshift-ci[bot] commented 54 minutes ago

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).