search

openshift / library-go

Helpers for going from apis and clients to useful runtime constructs
Apache License 2.0
94 stars 226 forks source link

OCPBUGS-23435: Fix Progressing and Degraded condition during workload rollouts. #1855

Open atiratree opened 1 day ago

atiratree commented 1 day ago

Degraded condtion should not become False during the deployment rollout (DeploymentProgressing condition. There can be unavailable pods during the rollout. This is capped by a 15 minute deadline.

Progressing condition should be True until all of the old pods have terminated as they can still accept connections.

followup for https://github.com/openshift/library-go/pull/1732

openshift-ci-robot commented 1 day ago

@atiratree: This pull request references Jira Issue OCPBUGS-23435, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/library-go/pull/1855): >Degraded condtion should not become False during the deployment rollout (DeploymentProgressing condition. There can be unavailable pods during the rollout. This is capped by a 15 minute deadline. > >Progressing condition should be True until all of the old pods have terminated as they can still accept connections. > >followup for https://github.com/openshift/library-go/pull/1732 > > >- fixes https://issues.redhat.com//browse/OCPBUGS-23435 >- partially fixes https://issues.redhat.com/browse/OCPBUGS-38675 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
atiratree commented 1 day ago

/jira refresh

openshift-ci-robot commented 1 day ago

@atiratree: This pull request references Jira Issue OCPBUGS-23435, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @xingxingxia

In response to [this](https://github.com/openshift/library-go/pull/1855#issuecomment-2430078951): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ardaguclu commented 1 day ago

/lgtm

openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ardaguclu, atiratree Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/operator/apiserver/OWNERS](https://github.com/openshift/library-go/blob/master/pkg/operator/apiserver/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 day ago

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).