OCPBUGS-42932: ensure annotations map exists before mutating it

[deads2k]

From failed run: https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/logs/periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-4.18-cpou-upgrade-from-4.15-aws-ipi-mini-perm-arm-f14/1842004955238502400

noteworthy log message:

2024-10-04T10:05:42.236079365Z E1004 10:05:42.236012       1 runtime.go:79] Observed a panic: "assignment to entry in nil map" (assignment to entry in nil map)
2024-10-04T10:05:42.236079365Z goroutine 2202 [running]:
2024-10-04T10:05:42.236079365Z k8s.io/apimachinery/pkg/util/runtime.logPanic({0x26081a0, 0x3005130})
2024-10-04T10:05:42.236079365Z  /go/src/github.com/openshift/cluster-authentication-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:75 +0x7c
2024-10-04T10:05:42.236079365Z k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x40014f7340, 0x1, 0x4003036000?})
2024-10-04T10:05:42.236079365Z  /go/src/github.com/openshift/cluster-authentication-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:49 +0x78
2024-10-04T10:05:42.236079365Z panic({0x26081a0?, 0x3005130?})
2024-10-04T10:05:42.236079365Z  /usr/lib/golang/src/runtime/panic.go:770 +0x124
2024-10-04T10:05:42.236079365Z github.com/openshift/library-go/pkg/operator/revisioncontroller.RevisionController.createNewRevision({{0x4000612de0, 0x22}, {0x2ac219c, 0x19}, {0x40016043a8, 0x1, 0x1}, {0x40016043c0, 0x1, 0x1}, ...}, ...)
2024-10-04T10:05:42.236079365Z  /go/src/github.com/openshift/cluster-authentication-operator/vendor/github.com/openshift/library-go/pkg/operator/revisioncontroller/revision_controller.go:308 +0x980
2024-10-04T10:05:42.236079365Z github.com/openshift/library-go/pkg/operator/revisioncontroller.RevisionController.createRevisionIfNeeded({{0x4000612de0, 0x22}, {0x2ac219c, 0x19}, {0x40016043a8, 0x1, 0x1}, {0x40016043c0, 0x1, 0x1}, ...}, ...)
2024-10-04T10:05:42.236079365Z  /go/src/github.com/openshift/cluster-authentication-operator/vendor/github.com/openshift/library-go/pkg/operator/revisioncontroller/revision_controller.go:118 +0x1c0

[openshift-ci-robot]

@deads2k: This pull request references Jira Issue OCPBUGS-42932, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/library-go/pull/1859): >From failed run: https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/logs/periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-4.18-cpou-upgrade-from-4.15-aws-ipi-mini-perm-arm-f14/1842004955238502400 > >noteworthy log message: > >``` >2024-10-04T10:05:42.236079365Z E1004 10:05:42.236012 1 runtime.go:79] Observed a panic: "assignment to entry in nil map" (assignment to entry in nil map) >2024-10-04T10:05:42.236079365Z goroutine 2202 [running]: >2024-10-04T10:05:42.236079365Z k8s.io/apimachinery/pkg/util/runtime.logPanic({0x26081a0, 0x3005130}) >2024-10-04T10:05:42.236079365Z /go/src/github.com/openshift/cluster-authentication-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:75 +0x7c >2024-10-04T10:05:42.236079365Z k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x40014f7340, 0x1, 0x4003036000?}) >2024-10-04T10:05:42.236079365Z /go/src/github.com/openshift/cluster-authentication-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:49 +0x78 >2024-10-04T10:05:42.236079365Z panic({0x26081a0?, 0x3005130?}) >2024-10-04T10:05:42.236079365Z /usr/lib/golang/src/runtime/panic.go:770 +0x124 >2024-10-04T10:05:42.236079365Z github.com/openshift/library-go/pkg/operator/revisioncontroller.RevisionController.createNewRevision({{0x4000612de0, 0x22}, {0x2ac219c, 0x19}, {0x40016043a8, 0x1, 0x1}, {0x40016043c0, 0x1, 0x1}, ...}, ...) >2024-10-04T10:05:42.236079365Z /go/src/github.com/openshift/cluster-authentication-operator/vendor/github.com/openshift/library-go/pkg/operator/revisioncontroller/revision_controller.go:308 +0x980 >2024-10-04T10:05:42.236079365Z github.com/openshift/library-go/pkg/operator/revisioncontroller.RevisionController.createRevisionIfNeeded({{0x4000612de0, 0x22}, {0x2ac219c, 0x19}, {0x40016043a8, 0x1, 0x1}, {0x40016043c0, 0x1, 0x1}, ...}, ...) >2024-10-04T10:05:42.236079365Z /go/src/github.com/openshift/cluster-authentication-operator/vendor/github.com/openshift/library-go/pkg/operator/revisioncontroller/revision_controller.go:118 +0x1c0 > >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[deads2k]

/jira refresh

[openshift-ci-robot]

@deads2k: This pull request references Jira Issue OCPBUGS-42932, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @xingxingxia

In response to [this](https://github.com/openshift/library-go/pull/1859#issuecomment-2435087070): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flibrary-go). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/operator/revisioncontroller/OWNERS](https://github.com/openshift/library-go/blob/master/pkg/operator/revisioncontroller/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[openshift-ci[bot]]

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).