search

openshift / lightspeed-operator

Operator for the OpenShift Lightspeed Service
Apache License 2.0
3 stars 21 forks source link

OLS-778, OLS-514: Update data collector configuration #347

Closed onmete closed 3 weeks ago

onmete commented 4 weeks ago

Description

Update data collector configuration according to these changes: https://github.com/openshift/lightspeed-service/pull/1364

Type of change

openshift-ci-robot commented 4 weeks ago

@onmete: This pull request references OLS-778 which is a valid jira issue.

This pull request references OLS-514 which is a valid jira issue.

In response to [this](https://github.com/openshift/lightspeed-operator/pull/347): >## Description > >Update data collector configuration according to these changes: https://github.com/openshift/lightspeed-service/pull/1364 > >## Type of change > >- [x] Refactor >- [x] New feature > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flightspeed-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
onmete commented 4 weeks ago

/hold

onmete commented 4 weeks ago

/assign @raptorsun

onmete commented 4 weeks ago

/retest

raptorsun commented 4 weeks ago

the logic looks good, just need to regenerate the bundle so that we have the new CRD in the bundle:

  1. update the bundle using this script 
    ./hack/update_bundle_catalog.sh
  2. revert changes in files other than the CSV file bundle/manifests/lightspeed-operator.clusterserviceversion.yaml
  3. revert the change in image references in the CSV file bundle/manifests/lightspeed-operator.clusterserviceversion.yaml
onmete commented 4 weeks ago

@raptorsun done

onmete commented 4 weeks ago

/retest

onmete commented 4 weeks ago

/test bundle-e2e-4-16

raptorsun commented 4 weeks ago

/retest

raptorsun commented 3 weeks ago

/lgtm /retest

raptorsun commented 3 weeks ago

/approve /unhold

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/lightspeed-operator/blob/main/OWNERS)~~ [raptorsun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
raptorsun commented 3 weeks ago

/override "Red Hat Konflux / ols-e2e-tests-rosa / bundle" /override "Red Hat Konflux / ols-e2e-tests-rosa / lightspeed-operator" /override "Red Hat Konflux / ols-enterprise-contract / bundle" /override "Red Hat Konflux / ols-enterprise-contract / lightspeed-operator"

openshift-ci[bot] commented 3 weeks ago

@raptorsun: Overrode contexts on behalf of raptorsun: Red Hat Konflux / ols-e2e-tests-rosa / bundle, Red Hat Konflux / ols-e2e-tests-rosa / lightspeed-operator, Red Hat Konflux / ols-enterprise-contract / bundle, Red Hat Konflux / ols-enterprise-contract / lightspeed-operator

In response to [this](https://github.com/openshift/lightspeed-operator/pull/347#issuecomment-2310487193): >/override "Red Hat Konflux / ols-e2e-tests-rosa / bundle" >/override "Red Hat Konflux / ols-e2e-tests-rosa / lightspeed-operator" >/override "Red Hat Konflux / ols-enterprise-contract / bundle" >/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-operator" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD a776b40a5b0e2a58a39352aa28afd5d656b49c06 and 2 for PR HEAD 87f6b457128f88b3f2d1cda3eb6229f6b41bd28a in total

openshift-ci[bot] commented 3 weeks ago

@onmete: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).